Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlatArray and Text #1856

Draft
wants to merge 54 commits into
base: develop
Choose a base branch
from
Draft

FlatArray and Text #1856

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
54 commits
Select commit Hold shift + click to select a range
e7a9248
Introduce Text type for BorrowDatum
workingjubilee Feb 23, 2024
1ed08e0
Template out FlatArray
workingjubilee Feb 23, 2024
40bb692
impl BorrowDatum for FlatArray
workingjubilee Feb 24, 2024
68815db
Sketch out some more fn for FlatArray
workingjubilee Feb 24, 2024
4e1004a
Copy nulls_mut into FlatArray
workingjubilee Feb 25, 2024
aac87d7
Add FlatArray::nulls
workingjubilee Feb 25, 2024
4934fd4
Document FlatArray pub fns
workingjubilee Feb 26, 2024
742bcf5
Oh that was wildly unsound
workingjubilee Feb 26, 2024
536c729
Fix imports
workingjubilee Feb 26, 2024
48b4933
Add unsafe {} for unsafe fn
workingjubilee Feb 26, 2024
b9a33c3
Completely redesign BorrowDatum
workingjubilee Feb 27, 2024
d845204
Fix BorrowDatum for FlatArray && Text
workingjubilee Feb 27, 2024
ba5e73f
Make FlatArray typecheck
workingjubilee Feb 28, 2024
1b91a9e
Make FlatArray::len public as FlatArray::count
workingjubilee Mar 20, 2024
e84d3d2
Draft an ArrayIter
workingjubilee Mar 20, 2024
e2ddff7
Pipe through RawArray in places
workingjubilee Apr 12, 2024
85ea44c
Finish unpacking the parts of the array
workingjubilee Apr 12, 2024
684005c
So now that just works
workingjubilee Apr 12, 2024
6b3ec58
Remove now-irrelevant code
workingjubilee Apr 12, 2024
c0f0238
mark incomplete code as incomplete
workingjubilee Apr 12, 2024
55b7543
use bitvec for MVP again
workingjubilee Apr 12, 2024
24c7648
comment on iter_mut design problems
workingjubilee Apr 12, 2024
f98cc2c
Split FlatArray into unconditional and conditional impls
workingjubilee Apr 12, 2024
848f2bc
fix doc link maybe
workingjubilee Sep 11, 2024
7cea9b7
Make PassBy less optional
workingjubilee Sep 13, 2024
3fa0675
Fixup text docs
workingjubilee Sep 26, 2024
fac7f1e
Address the TODO for Text
workingjubilee Sep 26, 2024
14c47ac
Elaborate on the Text API
workingjubilee Sep 27, 2024
df9d60d
Have a cow
workingjubilee Sep 27, 2024
3606a9a
obtain more confidence
workingjubilee Sep 27, 2024
ef7ac23
Round out FlatArray API
workingjubilee Sep 27, 2024
151af42
SqlTranslatable for &FlatArray
workingjubilee Sep 27, 2024
89a1f27
try to add some tests
workingjubilee Sep 27, 2024
10072ec
test revision
workingjubilee Sep 27, 2024
a8ca379
fixup tests more
workingjubilee Sep 27, 2024
960869e
fix all compile blockers for tests
workingjubilee Sep 27, 2024
2ed093f
Fix all test issuues
workingjubilee Sep 27, 2024
ea31e20
note stopping point in array iteration
workingjubilee Sep 27, 2024
e2294dc
partially implement iteration
workingjubilee Sep 27, 2024
6fca1e3
impl ArrayIter::next fully
workingjubilee Sep 28, 2024
e9ee7bd
fix up FlatArray for CStr
workingjubilee Sep 28, 2024
4fbe8c4
Add Dimensions support and another test
workingjubilee Sep 28, 2024
96b6d5d
Fixup another test
workingjubilee Sep 28, 2024
b67f095
Use BorrowDatum::borrow_unchecked inside FlatArray
workingjubilee Oct 1, 2024
c75dd1e
Move BorrowDatum interfaces to ptr::NonNull
workingjubilee Sep 28, 2024
82cb038
deny unsafe op in unsafe fn in all new code
workingjubilee Sep 28, 2024
cc020d4
impl TextData
workingjubilee Sep 28, 2024
347e1fb
move some doc text
workingjubilee Sep 28, 2024
05ed23d
typo in fn name
workingjubilee Sep 28, 2024
d69231f
Fixup docs a bit
workingjubilee Sep 28, 2024
f92a756
Add doc aliases
workingjubilee Sep 28, 2024
e2ba9ac
Add Iterator subtraits
workingjubilee Sep 28, 2024
7bce001
publicize ArrayIter
workingjubilee Oct 1, 2024
aaa6ed2
make some cstrings prettier
workingjubilee Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading