Use petgraph::algo::tarjan_scc to order the schema graph
#1867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to give a consistent ordering of the schema through consecutive runs of `cargo pgrx schema`. It also produces allows `diff` to produce nice diffs when the schema changes compared to a previous version
workingjubilee
approved these changes
Sep 18, 2024
|
Thanks for the merge and your time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems to give a consistent ordering of the schema through consecutive runs of
cargo pgrx schema.It also allows
diffto produce nice diffs when the schema changes compared to a previous version.Tossing this up here to see if CI blows up on any of the tests or examples due to the schema being out of order.
I've tested this ordering with the
pg_searchextension (which is quite large) and it still generates a perfectly usable schema. The same one from run to run, even!It also adds comment markers around each connected block of sql objects, just to help better visualize the connectedness of the schema.
Closes #1866