Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check whether expanded is a primitive #1028

Merged
merged 1 commit into from
Jul 2, 2021

Conversation

Skillmon
Copy link
Member

@Skillmon Skillmon commented Jul 2, 2021

Motivation for this change

In the lights of https://tex.stackexchange.com/questions/603455/beamer-error-due-to-pgf-package I think it is a good idea to test whether the \expanded primitive is available, and if not throw a meaningful error message and abort the current TeX run (similar to how the checks for e-TeX are currently enforced). This PR does just that inside of pgfkeys.code.tex in an engine independent way.

Checklist

Please check the boxes to explicitly state your agreement to these terms:

@Skillmon
Copy link
Member Author

Skillmon commented Jul 2, 2021

I just realised that the used test might fail in ConTeXt (do they really rename \expanded to \normalexpanded?). I'll have to test things there.

@Skillmon Skillmon marked this pull request as draft July 2, 2021 07:17
tex/generic/pgf/utilities/pgfkeys.code.tex Outdated Show resolved Hide resolved
@Skillmon Skillmon marked this pull request as ready for review July 2, 2021 07:25
Copy link
Member

@hmenke hmenke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please squash the two commits into one.

check whether expanded is a primitive

fix check in context
@hmenke hmenke merged commit afa8dcc into pgf-tikz:master Jul 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants