Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken example of simpledemo.lua to work with "simple demo layout" #1342

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hansonchar
Copy link

@hansonchar hansonchar commented Jun 25, 2024

Motivation for this change

I tried out the example at 36.2.1 The Hello World of Graph Drawing but it didn't compile:

\documentclass{standalone}
\usepackage{fp,pgf,tikz,xcolor}
\usetikzlibrary{graphs,graphdrawing} \usegdlibrary{simpledemo}
\begin{document}
\tikz [very simple demo layout]
  \graph { f -> c -> e -> a -> {b -> {c, d, f}, e -> b}};
\end{document}

It seems to me the culprit is the implementation in SimpleDemo.lua#L25-L39 differs from that in the documentation.

Checklist

@hansonchar
Copy link
Author

hansonchar commented Jun 25, 2024

The generated manual in pdf can be downloaded at here. I've also tested the changes locally and the example above now works.

I've subsequently forced push a better fix. Waiting for Github workflow to complete.

Signed-off-by: Hanson Char <hanson.char@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant