Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use luatexbase to register pgfsys@strcmp #1364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hmenke
Copy link
Member

@hmenke hmenke commented Oct 6, 2024

Motivation for this change

Workaround for latex3/latex2e#1100

Checklist

Please signoff your commits to explicitly state your agreement to the Developer Certificate of Origin. If that is not possible you may check the boxes below instead:

Signed-off-by: Henri Menke <henri@henrimenke.de>
@muzimuzhi
Copy link
Member

The logic looks OK to me, but overall my LuaTeX knowledge is not enough to review this PR.

As for l3kernel, it defines \tex_strcmp:D for LuaTeX using its own wrapper luacmd(name, func, ...), see here. Checking how luacmd() is defined, it loads ltluatex module if none of context and luatexbase are loaded and has a special branch if context module is loaded.

Linking to #1362 and don't forget to add a Changelog entry.

@hmenke hmenke added this to the 3.1.11 milestone Oct 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants