Improved version of #729 without questionable commits #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s in `extract.lua` - started adding libraries to the codeexamples
(so far not all needed styles and definitions were added using `pre` key)
…r files fail TeXing using the build bash script. ! `pre` stuff containing (double) hashes fail in automatic testing, because single hashes are needed there ! first `codeexample` in `pgfmanual-en-xxcolor.tex` isn't extracted (Is this a bug in `extract.lua`? Are there more `codeexamples` elsewhere that are not extracted?) ! second `codeexample` in pgfmanual-en-xxcolor.tex` shows spurious "-6pt-6pt" in the PDF in front of the `minipage` when TeXing the extracted file
- incorporated fixes from main PGF repository (provided by Henri)
- changed `\documentclass` from `article` to `standalone`
- reordered some stuff
- started switching from `libraries/tikz={...}` to `preamble={\usetikzlibrary{...}}`
…kzlibrary{...}}`
- continued with following files in the manual
- continued adding code to make extracted `codeexample`s work
(so they can be found more easily)
…unt for the manual files at `/tex/generic/pgf/graphdrawing/lua/pgf/` - accounted for some more `codeexample`s in `doc/generic/pgf/text-en/`
- started moving `setup code,hidden` to `preamble` of the `codeexample`s
…e `codeexample`s - minor stuff
- had a look at the `codeexample`s where a leading space was introduced (see pgf-tikz#711 (comment)). Some of them could be removed but others are introduced because of code added to the `pre` key where I don't have a clue if/how this can be avoided
…y" by default) - therefore added loading `graphs` library in `graphs.standard` library - adjusted `preamble` code in `codeexample`s accordingly - there exist `graphdrawing` `codeexample`s in the manual that don't need the `graphs` library --> adjusted `codeexample`s accordingly
… `pgfmanual-en-base-quick.tex` Co-Authored-By: Henri Menke <henri@icp.uni-stuttgart.de>
Mo-Gul
approved these changes
Aug 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I rebased the complete
Mo-Gul/masterbranch ontopgf-tikz/masterand dropped the botched merges.