Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop dependency on deprecated gulp-util #146

Merged
merged 1 commit into from
Feb 1, 2018
Merged

Drop dependency on deprecated gulp-util #146

merged 1 commit into from
Feb 1, 2018

Conversation

TheDancingCode
Copy link
Contributor

Closes #145

@pgherveou
Copy link
Owner

@TheDancingCode sorry for the late response,
Do you mind if I add you as a collaborator on this project? If you can ensure that tests pass
I would be happy to push a new version on npm.

@TheDancingCode
Copy link
Contributor Author

I can't really collaborate on this project. I'm not an AWS user, so I can't run the tests I'm afraid. Do the tests not pass?

@demurgos
Copy link

demurgos commented Jan 31, 2018

@pgherveou
The Gulp team is in the process of creating a new organization to host popular plugins and help maintainers (gulp-community). If you're looking for collaborators, it may interest you. There is still some preparation needed but there should be more info soon.

Regarding the PR itself it should be safe to merge it (patch update from a semver point of view).

@pioug pioug merged commit a364f07 into pgherveou:master Feb 1, 2018
@pioug
Copy link
Collaborator

pioug commented Feb 1, 2018

Tests are passing on my machine with a test bucket 👍

Though I am getting a growlnotify error related to mocha report (same error happening currently on master). I will fix that later.

I am merging and bumping. @pgherveou If you can double-check and publish on npm after 🙏

Thank everyone for your help!

@pgherveou
Copy link
Owner

Thks @pioug will do that asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants