-
Notifications
You must be signed in to change notification settings - Fork 864
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: date rounding errors for dates before 1970
millis % ONEDAY should be reworked to floorMod(millis, ONEDAY) Regular division "rounds" towards zero, however that is not what we want for dates Division "towards zero" results to adding a day for dates with "negative" long values. So we should use floorDiv/floorMod to get date/time components see #1499
- Loading branch information
Showing
5 changed files
with
112 additions
and
339 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.