Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for SQL function bodies #513

Closed
wants to merge 4 commits into from
Closed

Added support for SQL function bodies #513

wants to merge 4 commits into from

Conversation

toverdijk
Copy link
Contributor

@toverdijk toverdijk commented May 22, 2022 •
edited
Loading

Make sure that:

  • You have read the contribution guidelines.
  • You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
  • You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
  • You submit test cases (unit or integration tests) that back your changes.

Issue description

See #512

New Public APIs

N/A

Additional context

  • Renamed TokenizedSql to ParsedSql
  • Lexing/parsing is now done in two steps: first only tokenize, then parse into statements
  • Added support for function bodies ("BEGIN ATOMIC")
  • Added a test case for newly supported grammar

@toverdijk
- Renamed PostgresqlLexer to PostgresqlParser
4aef274 
- Renamed TokenizedSql to ParsedSql
- Lexing/parsing is now done in two steps: first only tokenize, then parse into statements
- Added support for function bodies ("BEGIN ATOMIC")
- Added a test case for newly supported grammar
@mp911de
Copy link
Collaborator

mp911de commented May 24, 2022

Thanks for the PR. The rename refactoring makes it impossible to identify the changes that enabled the new feature. Could you split the change into two commits (one that renames things, the other introducing the actual change) for easier review?

toverdijk added 3 commits May 24, 2022 17:11
@toverdijk
- Renamed PostgresqlLexer to PostgresqlParser
e3aa98d 
- Renamed TokenizedSql to ParsedSql
@toverdijk
- Lexing/parsing is now done in two steps: first only tokenize, then …
e55aab1 
…parse into statements

- Added support for function bodies ("BEGIN ATOMIC")
- Added a test case for newly supported grammar
@toverdijk
Merge remote-tracking branch 'origin/function-bodies' into function-b…
90f547f 
…odies
@toverdijk
Copy link
Contributor Author

I split the PR a bit, I hope it's reviewable now. I could've done a lot better, though. Can you work with this?

@mp911de mp911de added this to the 0.9.2.RELEASE milestone May 25, 2022
@mp911de mp911de added the type: enhancement A general enhancement label May 25, 2022
@mp911de
Copy link
Collaborator

mp911de commented May 25, 2022

Thanks a lot. I'm currently polishing up the PR and preparing for the merge.

mp911de pushed a commit that referenced this pull request May 25, 2022
@toverdijk @mp911de
Rename SQL parser components.
c74bd6e 
[#512][#513]
mp911de pushed a commit that referenced this pull request May 25, 2022
@toverdijk @mp911de
Extend PostgresqlSqlLexer to handle PG14 SQL-standard function body…
7f9b349 
… syntax

- Lexing/parsing is now done in two steps: first only tokenize, then parse into statements
- Added support for function bodies ("BEGIN ATOMIC")
- Added a test case for newly supported grammar

[resolves #512][#513]
mp911de added a commit that referenced this pull request May 25, 2022
@mp911de
Polishing.
b65db10 
Reorder methods. Use CharObjectMap for operator character lookup instead of linear array iteration. Extract peek/has next token functionality into dedicated methods.

Migrate assertions to AssertJ. Add benchmark.

[#512][resolves #513]

Signed-off-by: Mark Paluch <mpaluch@vmware.com>
mp911de pushed a commit that referenced this pull request May 25, 2022
@toverdijk @mp911de
Rename SQL parser components.
2752e98 
[#512][#513]
mp911de pushed a commit that referenced this pull request May 25, 2022
@toverdijk @mp911de
Extend PostgresqlSqlLexer to handle PG14 SQL-standard function body…
95fb4e0 
… syntax

- Lexing/parsing is now done in two steps: first only tokenize, then parse into statements
- Added support for function bodies ("BEGIN ATOMIC")
- Added a test case for newly supported grammar

[resolves #512][#513]
@mp911de mp911de closed this in 64f1621 May 25, 2022
@mp911de
Copy link
Collaborator

mp911de commented May 25, 2022

Thank you for your contribution. That's merged, polished, and backported now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: enhancement A general enhancement
Projects
None yet
Milestone
0.9.2.RELEASE
Development

Successfully merging this pull request may close these issues.
2 participants
@toverdijk @mp911de