Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plan to tap output #131

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

ndavies-om1
Copy link

Addresses #130

@pgrange
Copy link
Owner

pgrange commented Oct 17, 2024

Hi @ndavies-om1,

Thank you so much for contributing to bash_unit. I noticed the test fail with this change. Could you take a look at it?

Cheers,

@ndavies-om1
Copy link
Author

Hi @ndavies-om1,

Thank you so much for contributing to bash_unit. I noticed the test fail with this change. Could you take a look at it?

Cheers,

Pushed a fix - does this pass the tests now?

@ndavies-om1
Copy link
Author

Hi @ndavies-om1,

Thank you so much for contributing to bash_unit. I noticed the test fail with this change. Could you take a look at it?

Cheers,

I fixed the tap output tests now. However I get some unrelated test failures when I run locally. I am running on a mac.

@pgrange
Copy link
Owner

pgrange commented Nov 15, 2024

Hi @ndavies-om1,

Please consider this PR to amend your proposal.

Best,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants