SvmTrain #10
Merged
SvmTrain #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
August 18, 2017 22:41
TODO: Add useful dataset details in help output?
- Add Makefile - More skeleton code - Lots of TODOs!
pgrew
reviewed
Sep 5, 2017
| To see the available datasets, use: | ||
|
|
||
| ```bash | ||
| make help |
pgrew
reviewed
Sep 5, 2017
src/psvm/SvmTrain.chpl
Outdated
| use KernelType; | ||
|
|
||
|
|
||
| // TODO: Chapelify these names! |
There was a problem hiding this comment.
Chapel tends to use camelCase naming for variables, functions, object instances, etc.
There was a problem hiding this comment.
There's no official Chapel style guide (today), but some of the stylistic guidelines are being discussed in #6698
pgrew
reviewed
Sep 5, 2017
| proc innerProduct(a: Sample, b: Sample) { | ||
| var norm: real; | ||
|
|
||
| // TODO: Refactor as iterator: |
There was a problem hiding this comment.
Possibly! I'm happy to help you with that, if you're interested.
There was a problem hiding this comment.
Would you mind pushing this branch?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started
SvmTrain- work-in-progresscalcKernel