This repository has been archived by the owner on Mar 30, 2022. It is now read-only.
Altered webworker-child to permit the global worker object to be passed by reference. #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ould not be separated by contexts. The wrapped context limits the ability to pass the global worker object as an argument and for primordials to be shared between the require context and the worker context.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, using runInNewContext occludes the worker object, which it would be handy to be able to pass to an API for standard message passing setup.
I've also added a trivial example.
I would like to see the worker run as a module so relative module identifiers can be used inside the worker, relative to the worker file instead of the webworker-child module. This might require node to expose more of its module system primitives though.