Add v1 release schema #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the definition of the distribution schema into `base.schema.json` and remove `"additionalProperties": false`. Then mix it back into `distribution.schema.json` and set `"unevaluatedProperties": false`, and into the new `release.schema.json`, also with `"unevaluatedProperties": false`. This uses the JSON Schema mixin pattern to build on a base schema to share definitions between them. Finally, add tests for the new v1 release schema. While at it, skip clearing badges except in the main branch, as it's failing right now, and tweak convert some Markdown to HTML in the README so it displays properly.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #24 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 886 886
=========================================
Hits 886 886 ☔ View full report in Codecov by Sentry. |
vrmiguel
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the definition of the distribution schema into
base.schema.jsonand remove"additionalProperties": false. Then mix it back intodistribution.schema.jsonand set"unevaluatedProperties": false, and into the newrelease.schema.json, also with"unevaluatedProperties": false. This uses the JSON Schema mixin pattern to build on a base schema to share definitions between them.Finally, add tests for the new v1 release schema.
While at it, skip clearing badges except in the main branch, as it's failing right now, and tweak convert some Markdown to HTML in the README so it displays properly.