Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add certs, JWS, payload schemas #32

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Add certs, JWS, payload schemas #32

merged 1 commit into from
Oct 8, 2024

Conversation

theory
Copy link
Member

@theory theory commented Oct 8, 2024

Add certs, JWS, payload schemas

Following RFC 5, add new JSON schemas for a certs property containing JWS
JSON Serialization, supporting both the general and flattened syntaxes. The
schemas are:

  • certs.schema.json: One or more certifications, with the pgxn property required.
  • jws.schema.json: JWS general and flattened JSON Serialization
  • jws-header.schema.json: JWS headers
  • jwk.schema.json: RFC 7517 JSON Web Key (JWK) format, required by the jwk property of jws-header.schema.json
  • payload.schema.json: The PGXN release payload

Include tests for each of these schemas.

@theory theory requested a review from vrmiguel October 8, 2024 15:40
@theory theory self-assigned this Oct 8, 2024
@theory theory linked an issue Oct 8, 2024 that may be closed by this pull request
Following [RFC 5], add new JSON schemas for a `certs` property
containing JWS [JSON Serialization], supporting both the general and
flattened syntaxes. The schemas are:

*   `certs.schema.json`: One or more certifications, with the `pgxn`
    property required.
*   `jws.schema.json`: JWS general and flattened [JSON Serialization]
*   `jws-header.schema.json`: JWS headers
*   `jwk.schema.json`: [RFC 7517] JSON Web Key (JWK) format, required by
    the `jwk` property of `jws-header.schema.json`
*   `payload.schema.json`: The PGXN release payload

Include tests for each of these schemas, and fix comments for existing
schema tests.

  [RFC 5]: pgxn/rfcs#5
  [JSON Serialization]: https://datatracker.ietf.org/doc/html/rfc7515#section-7
  [RFC 7517]: https://datatracker.ietf.org/doc/html/rfc7517
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a5dbedd) to head (0773ad7).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #32   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         1083      1083           
=========================================
  Hits          1083      1083           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@theory theory merged commit 0773ad7 into main Oct 8, 2024
211 checks passed
@theory theory deleted the certs-schemas branch October 8, 2024 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Release metadata in pgxn_spec
2 participants