Add certs to release package #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the `certs` field to the `Release` struct and modify the `release` field to contain `ReleasePayload` parsed from the `pgxn` field of the `certs` hash map. Since the `release` field does not exist in the JSON, add custom deserialization to the `Release` struct that parses only the `dist` and `certs` fields and then extracts the `pgxn` JWS data and validates its base64-encoded JSON payload. No JWS validation yet, as the key management has not yet been worked out. Revise the `v1_to_v2_release` method to build an appropriate Base 64-encoded payload and mock signature from v1 release metadata. Add tests to ensure that the keys are included in the JSON in unicode code point order (alphabetical, since it's all lowercase ASCII) and that there are no spaces. Update the release tests for the new properties as well as the `certs` JSON schema.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1083 1131 +48
=========================================
+ Hits 1083 1131 +48 ☔ View full report in Codecov by Sentry. |
vrmiguel
reviewed
Oct 8, 2024
| release: ReleasePayload, | ||
| } | ||
|
|
||
| impl<'de> Deserialize<'de> for Release { |
vrmiguel
reviewed
Oct 8, 2024
| .get("payload") | ||
| .unwrap() | ||
| .as_str() | ||
| .unwrap(); |
vrmiguel
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
certsfield to theReleasestruct and modify thereleasefield to containReleasePayloadparsed from thepgxnfield of thecertshash map. Since thereleasefield does not exist in the JSON, add custom deserialization to theReleasestruct that parses only thedistandcertsfields and then extracts thepgxnJWS data and validates its base64-encoded JSON payload. No JWS validation yet, as the key management has not yet been worked out.Revise the
v1_to_v2_releasemethod to build an appropriate Base 64-encoded payload and mock signature from v1 release metadata. Add tests to ensure that the keys are included in the JSON in unicode code point order (alphabetical, since it's all lowercase ASCII) and that there are no spaces.Update the release tests for the new properties as well as the
certsJSON schema.