Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Genetic_variation_type #65

Closed
jodyphelan opened this issue Oct 11, 2021 · 1 comment · Fixed by #60
Closed

Genetic_variation_type #65

jodyphelan opened this issue Oct 11, 2021 · 1 comment · Fixed by #60
Assignees
@cimendes
Labels
blocked discussion enhancement New feature or request p0

Comments

@jodyphelan
Copy link
Contributor

At the moment the 'variant type' is set as non- mandatory but probably should be made mandatory. This attribute was added as part of the introduction of variant spec

hAMRonization/hAMRonization/hAMRonizedResult.py

Line 25 in ee85f6d

genetic_variation_type: str = None

@cimendes cimendes added discussion enhancement New feature or request labels Oct 12, 2021
@cimendes cimendes self-assigned this Jan 4, 2022
@cimendes cimendes added p0 p1 and removed p1 labels Jan 4, 2022
cimendes added a commit that referenced this issue Jan 18, 2022
@cimendes
update schema #27 #65
ccc05ab
@cimendes cimendes linked a pull request Jan 18, 2022 that will close this issue
Update AMR Gene Detection Scheme #60
Merged
4 tasks
@cimendes cimendes mentioned this issue Jan 18, 2022
Merged
4 tasks
@cimendes
Copy link
Member

Addressed in #60
genetic_variation_type is now a required field in the latest version of the spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cimendes cimendes

Labels
blocked discussion enhancement New feature or request p0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update AMR Gene Detection Scheme pha4ge/hAMRonization
2 participants
@jodyphelan @cimendes