Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove style components from PageHeader component #1284

Merged
merged 9 commits into from
Jun 10, 2022
Merged

Conversation

joshsadam
Copy link
Contributor

Description of changes

Starting to use CSS variables now that they are available in all major browsers. This allows us to start using theme and remove the kind of tacky colours.js file.

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and I'm glad we can use the css variables now. Just one comment but I'm open to leaving it the way it is. Can we put the css files in a css directory within the components? Just to keep the style files separate from the component files

@deepsidhu85
Copy link
Contributor

This looks good and I'm glad we can use the css variables now. Just one comment but I'm open to leaving it the way it is. Can we put the css files in a css directory within the components? Just to keep the style files separate from the component files

As per our discussion this is how we want to organize it so no changes need to be made

@ericenns ericenns merged commit 2b481f3 into development Jun 10, 2022
@ericenns ericenns deleted the css-variables branch June 10, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants