Typescript #1294
Merged
Typescript #1294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsadam
reviewed
May 31, 2022
Co-authored-by: Josh Adam <josh.adam@phac-aspc.gc.ca>
…ssociated projects object after mutations.
… function exports to normal functions.
joshsadam
approved these changes
Jun 7, 2022
| content: Activity[]; | ||
| } | ||
|
|
||
| export interface Activity { |
There was a problem hiding this comment.
I think this would be one of the items that we could bring up to the types' folder
| */ | ||
| export function getProjectActivities({ projectId, page = 0 }) { | ||
| export function getProjectActivities(projectId: number, page = 0): Promise<Activities> { | ||
| try { | ||
| return axios | ||
| .get(`${BASE_URL}/project?projectId=${projectId}&page=${page}`) |
There was a problem hiding this comment.
It seems to be best practice (from a number of examples I looked at) to type the request, so in this case:
return axios.get<ActivitiesResponse>()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Added in support for typescript and converted LoginForm to typescript as an example.
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted: