Switch to gradle for build instead of maven #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ration step before liquibase that is no longer required.
apetkau
requested changes
Jun 15, 2022
There was a problem hiding this comment.
Thanks so much for all of this Eric. It looks great. I am able to package up and run IRIDA using gradle.
I do have some comments below. Outside of that, I still do have trouble being able to build a production database. If it's already built (e.g., by running an older version of IRIDA), then I can run IRIDA with the prod Spring profile and it all works. But if it's not built then liquibase doesn't get run and I'm still not sure what I'm going wrong.
I was running with:
./gradlew bootRun --args="--irida.db.profile=prod --spring.profiles.active=prod"
|
One more comment, I think we should update |
…ing of gradle integration test tasks.
apetkau
requested changes
Jun 16, 2022
deepsidhu85
approved these changes
Jun 27, 2022
apetkau
approved these changes
Jun 28, 2022
|
Looks great. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Switched to Gradle from Maven for build scripts.
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenumformat. If it completes an issue, useFixes #issuenumto automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] Tests added (or description of how to test) for any new features.