-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing admins to change passwords for other user accounts #1330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksierks
force-pushed
the
allow-admins-to-change-user-passwords
branch
from
June 28, 2022 14:23
5658a12
to
7c040ab
Compare
ericenns
requested changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few comments below.
src/main/webapp/resources/js/pages/user/components/UserSecurityPage.jsx
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/ria/web/services/UIUsersService.java
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/ria/web/services/UIUsersService.java
Outdated
Show resolved
Hide resolved
src/main/java/ca/corefacility/bioinformatics/irida/ria/web/services/UIUsersService.java
Outdated
Show resolved
Hide resolved
ericenns
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks good to me, thanks for fixing this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Updated user account security page to allow admins to change passwords for other users
Related issue
N/A
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
[ ] Tests added (or description of how to test) for any new features.[ ] User documentation updated for UI or technical changes.