Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed analysis results manage results #1377

Merged
merged 2 commits into from
Oct 7, 2022

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Oct 6, 2022

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Updated logic to not allow project collaborators to see the Save results to samples section within the analysis results.

Project Manager
saveresultsprojmanager

Project User
saveresultsprojuser

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Fixes #1325

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

…o samples section on the analysis results -> manage results page
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out on my local IRIDA. It fixes the issue. Thanks so much @deepsidhu85

@deepsidhu85 deepsidhu85 added UI User Interface Issue bug labels Oct 7, 2022
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This is now working as expected, thanks!

@ericenns ericenns merged commit deaecb2 into phac-nml:development Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug UI User Interface Issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Save Results" section is visible for users who don't have permission to save results to samples
3 participants