Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata uploader restrictions #1383

Merged
merged 49 commits into from
Nov 23, 2022

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Oct 17, 2022

Description of changes

Changes made to the "Map Headers" Step:

  • displayed sample name list in a drop-down
  • displayed headers table on header selection
  • made headers table scrollable
  • changed restrictions to a radio button group
  • pre-populated restrictions if field already exists

Other changes:

  • removed trailing & leading whitespace from data files
  • stored state in seperate sessions for each project (expiry is 6 hours)
  • cleared state on import initialization
  • removed auto redirect at completion
  • changed button on completion to navigate to projects page
  • ensured metadata fields, restrictions, & entries are updated if they already exist
  • created new api endpoint to create metadata fields & restrictions before entries are created to solve race condition
  • prevented import from happening to locked samples

Note: I will create a separate PR for tests

MicrosoftTeams-image
9-11-2022

Related issue

N/A

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • [ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • [ ] Tests added (or description of how to test) for any new features.
  • [ ] User documentation updated for UI or technical changes.

Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great start, I am liking how it is going. I made a couple UI suggestions that might get the page to work a little bit better.

@ksierks ksierks requested a review from joshsadam November 7, 2022 21:04
@ksierks ksierks marked this pull request as ready for review November 14, 2022 16:57
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this out and it works as expected. I have a few comments on code naming and code structure.

@joshsadam joshsadam merged commit d11153b into metadata-uploader-base Nov 23, 2022
@ksierks ksierks mentioned this pull request Jan 13, 2023
3 tasks
@ksierks ksierks deleted the metadata-uploader-restrictions branch January 23, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants