-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Metadata uploader restrictions #1383
Metadata uploader restrictions #1383
Conversation
… metadata entry creation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a really great start, I am liking how it is going. I made a couple UI suggestions that might get the page to work a little bit better.
...rces/js/pages/projects/samples-metadata-import/components/SampleMetadataImportMapHeaders.tsx
Outdated
Show resolved
Hide resolved
...rces/js/pages/projects/samples-metadata-import/components/SampleMetadataImportMapHeaders.tsx
Outdated
Show resolved
Hide resolved
...rces/js/pages/projects/samples-metadata-import/components/SampleMetadataImportMapHeaders.tsx
Outdated
Show resolved
Hide resolved
...rces/js/pages/projects/samples-metadata-import/components/SampleMetadataImportMapHeaders.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this out and it works as expected. I have a few comments on code naming and code structure.
.../java/ca/corefacility/bioinformatics/irida/ria/web/ajax/projects/dto/MetadataFieldModel.java
Outdated
Show resolved
Hide resolved
.../java/ca/corefacility/bioinformatics/irida/ria/web/ajax/projects/dto/MetadataFieldModel.java
Outdated
Show resolved
Hide resolved
…ample details modal
Description of changes
Changes made to the "Map Headers" Step:
Other changes:
Note: I will create a separate PR for tests
9-11-2022
Related issue
N/A
Checklist
Things for the developer to confirm they've done before the PR should be accepted:
[ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.[ ] Tests added (or description of how to test) for any new features.[ ] User documentation updated for UI or technical changes.