Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Object store/ docs #1394

Merged
merged 8 commits into from
Jan 27, 2023
Merged

Conversation

deepsidhu85
Copy link
Contributor

@deepsidhu85 deepsidhu85 commented Oct 31, 2022

Description of changes

What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

* [ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
* [ ] Tests added (or description of how to test) for any new features.

  • User documentation updated for UI or technical changes.

@deepsidhu85 deepsidhu85 added documentation Issues relating to IRIDA's documentation developer Issues effecting developers of IRIDA, but that aren't user facing labels Oct 31, 2022
@deepsidhu85 deepsidhu85 changed the base branch from development to object-store October 31, 2022 01:16
@deepsidhu85 deepsidhu85 marked this pull request as ready for review January 26, 2023 19:07
@deepsidhu85 deepsidhu85 requested a review from ericenns January 26, 2023 20:07
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ericenns ericenns merged commit 63f244b into phac-nml:object-store Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
developer Issues effecting developers of IRIDA, but that aren't user facing documentation Issues relating to IRIDA's documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants