Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix add associated project to cart #1395

Merged
merged 6 commits into from
Nov 1, 2022

Conversation

joshsadam
Copy link
Contributor

Description of changes

Fixes issue the results in samples from associated projects to be added to the cart under the wrong project identifier.

Related issue

Fixes #1392

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@joshsadam joshsadam changed the base branch from development to master November 1, 2022 02:05
@joshsadam joshsadam marked this pull request as ready for review November 1, 2022 02:55
@joshsadam joshsadam requested review from ericenns and apetkau November 1, 2022 02:56
@ericenns ericenns force-pushed the hotfix-add-associated-project-to-cart branch from 5e14f70 to fdea8e6 Compare November 1, 2022 16:37
@ericenns ericenns force-pushed the hotfix-add-associated-project-to-cart branch from 859a897 to 445a452 Compare November 1, 2022 17:45
Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I just verified that this PR fixes this issue, thanks @joshsadam

@ericenns ericenns merged commit 76bdf71 into master Nov 1, 2022
@ericenns ericenns deleted the hotfix-add-associated-project-to-cart branch November 1, 2022 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Samples from associated projects cannot be added to the cart
2 participants