Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOTFIX: Fixed issue with export file and instrument model using the NCBI Exporter #1439

Merged
merged 7 commits into from
Dec 21, 2022

Conversation

joshsadam
Copy link
Contributor

@joshsadam joshsadam commented Dec 16, 2022

Description of changes

The NCBI export page was failing to actually export samples :(. This is lousy.

What was wrong:

  • Files were not sent as a required field. This has been updated now.
  • Sample field values were not properly being sent. The structure of the field was field: {value: VALUE}, and was attempting to send it as such. This was fixed by getting the actual value and sending it.

To test:

  1. Select samples (that have files) from the project samples page.
  2. From the menu above the table: Export > Upload to NCBI SRA
  3. Fill in the fields for the submission details.
  4. Select sample default values or fill in values for each sample.
  5. To check the files, open up a sample collapsed region and select then deselect a file. A message should be displayed underneath them that shows the error message. Selecting another file should remove that error.
  6. Once all fields are filled in, click submit.
  7. If it redirects back to the project samples page then the submission was successful.

Related issue

Link to the GitHub issue this pull request addresses using the #issuenum format. If it completes an issue, use Fixes #issuenum to automatically close the issue.

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
    * [ ] User documentation updated for UI or technical changes.

@joshsadam joshsadam added bug critical Urgently required bugfixes or issues javascript Pull requests that update Javascript code labels Dec 16, 2022
@joshsadam joshsadam marked this pull request as ready for review December 19, 2022 20:49
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to test it out but here are a few small things to update

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me

@ericenns ericenns merged commit 341832e into master Dec 21, 2022
@ericenns ericenns deleted the hotfix-ncbi-export branch April 14, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug critical Urgently required bugfixes or issues javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants