-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOTFIX: Fixed issue with export file and instrument model using the NCBI Exporter #1439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshsadam
added
bug
critical
Urgently required bugfixes or issues
javascript
Pull requests that update Javascript code
labels
Dec 16, 2022
deepsidhu85
requested changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still need to test it out but here are a few small things to update
src/main/webapp/resources/js/pages/projects/ncbi/create/CreateNcbiExport.tsx
Outdated
Show resolved
Hide resolved
src/main/webapp/resources/js/pages/projects/ncbi/create/CreateNcbiExport.tsx
Outdated
Show resolved
Hide resolved
src/main/webapp/resources/js/pages/projects/ncbi/create/CreateNcbiSampleDetails.tsx
Outdated
Show resolved
Hide resolved
deepsidhu85
approved these changes
Dec 21, 2022
ericenns
approved these changes
Dec 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 looks good to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
critical
Urgently required bugfixes or issues
javascript
Pull requests that update Javascript code
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
The NCBI export page was failing to actually export samples :(. This is lousy.
What was wrong:
field: {value: VALUE}
, and was attempting to send it as such. This was fixed by getting the actual value and sending it.To test:
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenum
format. If it completes an issue, useFixes #issuenum
to automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] User documentation updated for UI or technical changes.