-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated service layer for adding user group to project to validate if… #1483
Merged
ericenns
merged 10 commits into
fix-remove-template-field
from
fix-duplicate-user-group-projects
Apr 14, 2023
Merged
Updated service layer for adding user group to project to validate if… #1483
ericenns
merged 10 commits into
fix-remove-template-field
from
fix-duplicate-user-group-projects
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the user group is already linked to the project or not, if so then throw an exception. Fixed bug with html.zip files throwing a no file exists exception which was causing analyses with html output files from reaching the completed stage
src/main/java/ca/corefacility/bioinformatics/irida/service/impl/ProjectServiceImpl.java
Outdated
Show resolved
Hide resolved
…in the user_group_project table to prevent duplicate entries, and to delete duplicated entries in the table
… to project modal to initial values. Added a catch for error messages. Updated comparison
…ml/irida into fix-duplicate-user-group-projects
…l drive and those that don't. Added check to isZippedFile test to check if an exception is thrown for a file not found
deepsidhu85
added
UI
User Interface Issue
back-end
Issues relating to the service layer, repository, model, configuration, or database
labels
Apr 14, 2023
ericenns
approved these changes
Apr 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
What did you change in this pull request? Provide a description of files changed, user interactions changed, etc. Include how to test your changes.
Updated service layer for adding user group to project to validate if the user group is already linked to the project or not, if so then throw an exception, and added unique constraint to the user_group_project table to prevent duplicate entries from being added for the combination of user_group_id and project_id.
Fixed Project -> Add user group to project modal to actually reset the modal values once the modal has closed after successfully adding a group to the project. Before the fix if the user didn't leave the user group page and tried to add a group again, it would allow them to select the same group from the listing even though it had already been linked.
Fixed bug with html files throwing a no file exists exception which was causing analyses with html output files from reaching the completed stage when the file hadn't yet persisted to disk
To test values not being cleared and duplicate entries:
Manager
Manager
andLevel 4
for the project and metadata roles respectivelyTo test values being cleared and no more duplicate entries:
Manager
To test the bug of html files causing analyses from reaching the completed stage
To test the fix html files causing analyses from reaching the completed stage
Related issue
Link to the GitHub issue this pull request addresses using the
#issuenum
format. If it completes an issue, useFixes #issuenum
to automatically close the issue.Checklist
Things for the developer to confirm they've done before the PR should be accepted:
* [ ] User documentation updated for UI or technical changes.