-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update/docs #56
Update/docs #56
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a few additional comments regarding (very minor) typos or suggested re-wording, but all changes look good to me.
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
Merging branch so that parameters with their fixed spelling are merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes look good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Updating docs and some typos in parameters. I am making the PR to dev as I changed the spelling of some parameters and I want to perform additional testing to make sure everything works.