Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/docs #56

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Update/docs #56

merged 6 commits into from
Apr 10, 2024

Conversation

mattheww95
Copy link
Collaborator

Updating docs and some typos in parameters. I am making the PR to dev as I changed the spelling of some parameters and I want to perform additional testing to make sure everything works.

Copy link

github-actions bot commented Mar 28, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit dd0b7c9

+| ✅ 146 tests passed       |+
#| ❔  31 tests were ignored |#
!| ❗   3 tests had warnings |!

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 0.1.0
  • readme - README contains the placeholder zenodo.XXXXXXX. This should be replaced with the zenodo doi (after the first release).
  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/mikrokondo/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/mikrokondo/main/nextflow_schema.json

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-mikrokondo_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mikrokondo_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-mikrokondo_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: docs/output.md
  • files_exist - File is ignored: docs/README.md
  • files_exist - File is ignored: docs/usage.md
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-mikrokondo_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-mikrokondo_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-mikrokondo_logo_dark.png
  • files_unchanged - File does not exist: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore or pyproject.toml
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/mikrokondo/mikrokondo/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 2.13.1
  • Run at 2024-04-10 16:01:00

Copy link
Collaborator

@dpbastedo dpbastedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a few additional comments regarding (very minor) typos or suggested re-wording, but all changes look good to me.

docs/usage/tool_params.md Outdated Show resolved Hide resolved
docs/usage/tool_params.md Outdated Show resolved Hide resolved
docs/usage/usage.md Outdated Show resolved Hide resolved
docs/usage/usage.md Outdated Show resolved Hide resolved
@mattheww95 mattheww95 marked this pull request as ready for review April 10, 2024 15:59
mattheww95 and others added 4 commits April 10, 2024 10:59
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
Co-authored-by: dpbastedo <45338596+dpbastedo@users.noreply.github.com>
@mattheww95
Copy link
Collaborator Author

Merging branch so that parameters with their fixed spelling are merged.

@mattheww95 mattheww95 merged commit 85efc07 into dev Apr 10, 2024
4 checks passed
@mattheww95 mattheww95 deleted the update/docs branch April 10, 2024 17:23
Copy link
Collaborator

@dpbastedo dpbastedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Collaborator

@dpbastedo dpbastedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes look good!

Copy link
Collaborator

@dpbastedo dpbastedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants