Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

String encoding #37

Merged
merged 5 commits into from
Nov 7, 2019
Merged

String encoding #37

merged 5 commits into from
Nov 7, 2019

Conversation

jrober84
Copy link
Collaborator

@jrober84 jrober84 commented Nov 6, 2019

This commit is to address bug identified in issue #36 for non-ascii characters along with minor improvements to code documentation for versioning as requested in issue #35

@kbessonov1984
Copy link
Collaborator

kbessonov1984 commented Nov 6, 2019

All is looking good. I am wondering why mcl_predict() function was removed in this commit. I am also right now testing in Debian container under different locale.
Decided to also add code to resolve issue #38 and #39.
Testing with locale POSIX and if all test will pass, then will merge PR into master.

Note: mcl_predict() was an orphan code from cluster prediction using markov chain clustering.

…databases directory as issue #38. Also changed python calls to sys.executable as per issue #39
…3 functions to query right datbase location. Implemeted ete3 init upon first time mob_hostrange call (if no other module was never ever called). Inserted lock function for ete3 init to again avoid a race condition on HPC clusters
…. Corrected the test_mobrecon function to correctly read aggregate report files. Added system locale independent open file encoding statements
@kbessonov1984
Copy link
Collaborator

Pretty happy with this 2.0.2 release as I see it more robust. Thank you everyone for patience

@kbessonov1984 kbessonov1984 merged commit 327b310 into master Nov 7, 2019
Copy link
Collaborator

@kbessonov1984 kbessonov1984 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants