\PDO:: class constant aliases (request)

[cottton]

By merging multiple service configs like

 return [
     'database' => [
         'adapter'    => '...',
         // ...
         'persistent' => '...',
         'options'    => [
             \PDO::MYSQL_ATTR_INIT_COMMAND => "...",
         ],
     ]
 ];

we got a problem with numeric keys (integer).
F.e. \PDO::MYSQL_ATTR_INIT_COMMAND === 1002.
So we get a actual config of:

 return [
     'database' => [
         'adapter'    => '...',
         // ...
         'persistent' => '...',
         'options'    => [
             1002 => "...",
         ],
     ]
 ];

In PHP if merging multiple configs we get renumbered keys ofc.
Example:

 // config 1
 return [
     'database' => [
         'adapter' => '...',
         // ...
         'options' => [
             \PDO::MYSQL_ATTR_INIT_COMMAND => "...",
         ],
     ]
 ];

 // config 2
 return [
     'database' => [
         'adapter' => '...',
         // ...
         'options' => [
             \PDO::MYSQL_ATTR_INIT_COMMAND => "...",
         ],
     ]
 ];

 // merged result
 return [
     'database' => [
         'adapter' => '...',
         // ...
         'options' => [
             0 => "...", 
             1 => "...",
         ],
     ]
 ];

The fatal here is that the key 0 will end up as a "AUTOCOMMIT=0".

To tmp fix that we can force keys to strings like

 'options' => [
     (string)\PDO::MYSQL_ATTR_INIT_COMMAND => "...",
],

To fix this perm i suggest allowing aliasses.
mysql_attr_init_command for \PDO::MYSQL_ATTR_INIT_COMMAND.

Im not into zephir. I cannot provide a PR. But i can provide the code in PHP.
Would be nice if somebody could convert that into zep for me.

Where to put:

https://github.com/phalcon/cphalcon/blob/master/phalcon/db/adapter/pdo.zep#L130

What to put:

// check for \PDP::XXX class constant aliasses
foreach ($options as $key => $value) {
    if (is_string($key) && defined(\PDO::class . "::" . strtoupper($key))) {
        $options[constant(\PDO::class . "::" . strtoupper($key))] = $value;
        unset($options[$key]);
    }
}

Thanks,
cottton

[stamster]

Well, this is from Phalcon's config object and toArray() method:

Array
(
    [host] => db.lxc
    [username] => myUser
    [password] => myPass
    [dbname] => myDb
    [charset] => UTF8
    [persistent] => 1
    [options] => Array
        (
            [19] => 5
        )

)

//19 => 5  originally was set as: \PDO::ATTR_DEFAULT_FETCH_MODE => \PDO::FETCH_OBJ

and vanilla PHP:

$m = [
\PDO::ATTR_DEFAULT_FETCH_MODE => \PDO::FETCH_OBJ,
\PDO::ATTR_ERRMODE => \PDO::ERRMODE_EXCEPTION,
\PDO::ATTR_EMULATE_PREPARES => 0,
\PDO::MYSQL_ATTR_FOUND_ROWS => 1
];

print_r($m);

Array
(
    [19] => 5
    [3] => 2
    [20] => 0
    [1005] => 1
)

So those constants will always be converted internally to integer values, since that's what they are - you're using constant name in order to get it's value.

[cottton]

I know. Thats why im asking to add the alias feature.
in your example i would like to provide a config:

$m = [
    'attr_default_fetch_mode' => \PDO::FETCH_OBJ,
    'attr_errmode'            => \PDO::ERRMODE_EXCEPTION,
    'attr_emulate_prepares'   => 0,
    'mysql_attr_found_rows'   => 1
];

Test

// simulated options
$options = [
    'attr_default_fetch_mode' => \PDO::FETCH_OBJ,
    'attr_errmode'            => \PDO::ERRMODE_EXCEPTION,
    'attr_emulate_prepares'   => 0,
    'mysql_attr_found_rows'   => 1
];


// check for \PDP::XXX class constant aliasses
foreach ($options as $key => $value) {
    if (is_string($key) && defined(\PDO::class . "::" . strtoupper($key))) {
        $options[constant(\PDO::class . "::" . strtoupper($key))] = $value;
        unset($options[$key]);
    }
}


echo var_export($options);
// array (
//     19 => 5,
//     3 => 2,
//     20 => 0,
//     1005 => 1,
// )

Works fine. I just dont have enough knowledge about zep to provide a PR.

[sergeyklay]

Implemented in the 3.3.x branch. Thank you for contributing.