Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add convert method to the Phalcon\Mvc\Router\RouteInterface #13380

Closed
sergeyklay opened this issue May 16, 2018 · 1 comment
Closed

Add convert method to the Phalcon\Mvc\Router\RouteInterface #13380

sergeyklay opened this issue May 16, 2018 · 1 comment
Labels
breaks bc Functionality that breaks Backwards Compatibility
Milestone
4.0.0

Comments

@sergeyklay
Copy link
Contributor

sergeyklay commented May 16, 2018 •
edited
Loading

The documentation for Phalcon\Mvc\Router\Group::add states, that add() on a group would return an instance of RouteInterface but it really returns an instance of Route.

After calling add we shouldn't call convert because convert is a Route member but not RouteInterface.
@sergeyklay sergeyklay added this to the 4.0.0 milestone May 16, 2018
@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label May 16, 2018
@sergeyklay sergeyklay mentioned this issue May 16, 2018
Closed
@sergeyklay sergeyklay changed the title Add convert method to the Phalcon\Mvc\RouteInterface Add convert method to the Phalcon\Mvc\Router\RouteInterface May 31, 2018
@sergeyklay sergeyklay mentioned this issue May 31, 2018
Merged
3 tasks
@sergeyklay
Copy link
Contributor Author

Implemented in the 4.0.x branch.

@niden niden mentioned this issue Oct 19, 2018
Closed
10 tasks
@niden niden added the 4.0 label Jun 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaks bc Functionality that breaks Backwards Compatibility
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
2 participants
@niden @sergeyklay