Skip to content

Added RouteInterface::convert #13392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2018
Merged

Added RouteInterface::convert #13392

merged 1 commit into from
May 31, 2018

Conversation

sergeyklay
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Added Phalcon\Mvc\Router\RouteInterface::convert so that calling Phalcon\Mvc\Router\Group::add will return an instance that has convert method #13380

Thanks

@sergeyklay sergeyklay added new feature request Planned Feature or New Feature Request discussion Request for comments and discussion breaks bc Functionality that breaks Backwards Compatibility labels May 31, 2018
@sergeyklay sergeyklay added this to the 4.0.0 milestone May 31, 2018
@sergeyklay sergeyklay self-assigned this May 31, 2018
@sergeyklay sergeyklay merged commit 082380e into 4.0.x May 31, 2018
@sergeyklay sergeyklay deleted the feature/route-interface-convert branch May 31, 2018 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sergeyklay sergeyklay

Labels
breaks bc Functionality that breaks Backwards Compatibility discussion Request for comments and discussion new feature request Planned Feature or New Feature Request
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@sergeyklay