Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisEngine setTimeout has deprecated #14281

Closed
alex-aff opened this issue Aug 4, 2019 · 9 comments
Closed

RedisEngine setTimeout has deprecated #14281

alex-aff opened this issue Aug 4, 2019 · 9 comments
Labels
bug A bug report status: low Low
Milestone

Comments

@alex-aff
Copy link

alex-aff commented Aug 4, 2019

setTimeout function of Redis has deprecated so it should be replaced by expire function.
right now it is throwing following exception.

Redis::setTimeout() is deprecated

phpredis/phpredis#1572

  • PHP Version: >7.0
  • Redis Version: >5.0.0
@CameronHall
Copy link
Contributor

We don't use setTimeout anywhere so this should be okay to close.

@sergeyklay
Copy link
Contributor

Fixed in the 4.0.x branch: #14284. Feel free to open a new issue if the problem appears again. Thank you for contributing.

@alex-aff
Copy link
Author

alex-aff commented Aug 7, 2019

@sergeyklay understood . However version v3.4.x still uses setTimeout(). Shouldn't we fix it for that version?
https://github.com/phalcon/cphalcon/blob/3.4.x/phalcon/cache/backend/redis.zep#L261

@jesugmz
Copy link

jesugmz commented Aug 9, 2019

Same issue here for v3.4.4 and PhpRedis 5.0.2.
As v3.4.4 is the recomended version in https://phalconphp.com/en/ you should reconsider to reopen this issue @sergeyklay.

@SergioFloresG
Copy link

Same issue in.

  • PHP 7.1
  • Phalcon 3.4.4
  • Redis 5

When run i get this message.

( ! ) Deprecated: Function Redis::setTimeout() is deprecated in Unknown on line 0

And my config is this.

$session = new SessionRedis([
    'host' => env('REDIS_HOST'),
    'port' => env('REDIS_PORT', 6379),
    'persistent' => false,
    'uniqueId' => env('SESSION_ID', 'my-app'),
    'lifetime' => env('SESSION_LIFETIME', 3600),
    'prefix' => env('SESSION_PREFIX', 'my_')
]);

@sergeyklay
Copy link
Contributor

We're not plan to release 3.x in near future. I'm sorry. In other hand, there are simple steps to build Phalcon from source code. This is so easily done that everyone can do it himself. Feel free to ping me in case of any building problem.

@sergeyklay
Copy link
Contributor

We're release Phalcon v3.4.5 right now

@mahen3d
Copy link

mahen3d commented Dec 16, 2020

version 3.4.5 still has this issue

@Jeckerson
Copy link
Member

@mahen3d As far, as I remember, you need to make own build from 3.4.x branch - https://github.com/phalcon/cphalcon/tree/3.4.x

Latest 3.4.5 version do not contain that fix.

See, for more details - https://docs.phalcon.io/3.4/en/installation#compile-from-sources

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

No branches or pull requests

8 participants