Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Storage\Adapter\Redis::settimeout #14500

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Conversation

nanotronic
Copy link

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Small description of change:
Replace deprecated settimeout function with expire
Thanks

Replace settimeout with expire
@sergeyklay sergeyklay merged commit 3c5b000 into phalcon:3.4.x Oct 31, 2019
@sergeyklay
Copy link
Contributor

Thank you!

@nanotronic nanotronic deleted the 3.4.x branch October 31, 2019 13:35
@nanotronic
Copy link
Author

Any chance for another bugfix release in the next weeks?

@sergeyklay
Copy link
Contributor

Well, in general it's possible. Let's find something else to fix for 3.4.x

@nanotronic
Copy link
Author

Any pointers for low hanging fruits?

@sergeyklay
Copy link
Contributor

Nope :-/

@niden niden added 4.0 labels Dec 2, 2019
@niden niden added bug A bug report status: low Low and removed Bug - Low labels Dec 23, 2019
@aleho
Copy link

aleho commented Feb 21, 2020

ext/phalcon/cache/backend/redis.zep.c still uses settimeout. Is this an onversight or generated on release only?

@sergeyklay
Copy link
Contributor

sergeyklay commented Feb 21, 2020

@aleho Usually this is re-generated before release. You can easily regenerate C-code for Phalcon 3.x using Zephir 0.10.x

@someson
Copy link

someson commented Feb 14, 2021

if you're using the url like https://github.com/phalcon/cphalcon/archive/v3.4.5.tar.gz to install phalcon, there is only "settimeout" call used in /cphalcon-3.4.5/build/php7/64bits/*. Expected "expire" not found. Did someone forgot to regenerate the c files after this commit was merged?
So this still isn't fixed. Please correct me if i'm wrong.

@Jeckerson
Copy link
Member

@someson if it is the case, you will need to regenerate by yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants