Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFR]: Remove iconv dependency #14912

Closed
niden opened this issue Mar 13, 2020 · 1 comment
Closed

[NFR]: Remove iconv dependency #14912

niden opened this issue Mar 13, 2020 · 1 comment
Assignees
@niden
Labels
documentation Documentation required new feature request Planned Feature or New Feature Request

Comments

@niden
Copy link
Member

niden commented Mar 13, 2020

iconv is used in Volt (convertEncoding). It needs to be removed since it is has a number of bugs in macOS and Windows. The method offers utf8_encode as well as mb_convert_string functionality and can be extended if need be for custom implementations
@niden niden added new feature request Planned Feature or New Feature Request 4.0.6 documentation Documentation required labels Mar 13, 2020
@niden niden mentioned this issue Mar 13, 2020
Merged
5 tasks
niden added a commit that referenced this issue Mar 13, 2020
@niden
[#14912] - Removed iconv from Volt::convertEncoding
5b6a3b8
niden added a commit that referenced this issue Mar 13, 2020
@niden
[#14912] - Updated changelog
6c09e7f
niden added a commit that referenced this issue Mar 13, 2020
@niden
[#14912] - Updated changelog [ci-skip]
a83bc47
@niden
Copy link
Member Author

niden commented Mar 13, 2020

Resolved in #14913

@niden niden closed this as completed Mar 13, 2020
@niden niden self-assigned this Mar 13, 2020
niden added a commit that referenced this issue Mar 20, 2020
@niden
Merge branch '4.0.x' of github.com:phalcon/cphalcon into 4.0.x
c705242 
* '4.0.x' of github.com:phalcon/cphalcon: (62 commits)
  [#13655] - Added more tests
  [#13655] - Added one more test for get/set
  [#13655] - Hangout test!!
  [4.0.x] - Minor refector
  [4.0.x] - Correcting test
  [4.0.x] - Minor correction
  [4.0.x] - Updated Request tests
  [#14639] - Added test for model paginate
  [#14639] - Trying phpunit 8.5
  [#14639] - Removed sqlite from test
  [#14639] - Added test
  [#14907] - Updated changelog
  [#14907] - Removed cache parsing from Volt
  [#14912] - Updated changelog [ci-skip]
  [#14912] - Updated changelog
  [#14912] - Removed iconv from Volt::convertEncoding
  Deleted Makefile
  [#14866] - Enabling tests
  [#14866] - Updated changelog
  [#14866] - Changed the friendlyTitle to not rely on iconv
  ...
niden added a commit that referenced this issue May 16, 2020
@niden
[#14912] - Removed iconv from Volt::convertEncoding
a05cc14
niden added a commit that referenced this issue May 16, 2020
@niden
[#14912] - Updated changelog
b2be555
niden added a commit that referenced this issue May 16, 2020
@niden
[#14912] - Updated changelog [ci-skip]
41042f6
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niden niden

Labels
documentation Documentation required new feature request Planned Feature or New Feature Request
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@niden