Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG]: Incorrect return type hint for Phalcon\Http\Response\Cookies::setSignKey #14982

Closed
sergeyklay opened this issue May 2, 2020 · 1 comment · Fixed by #14984
Closed

[BUG]: Incorrect return type hint for Phalcon\Http\Response\Cookies::setSignKey #14982

sergeyklay opened this issue May 2, 2020 · 1 comment · Fixed by #14984
Assignees
@sergeyklay
Labels
bug A bug report status: low Low

Comments

@sergeyklay
Copy link
Contributor

Phalcon\Http\Response\Cookies::setSignKey has incorrect return type hint:

cphalcon/phalcon/Http/Response/Cookies.zep

Lines 315 to 320 in d3e9463

public function setSignKey(string signKey = null) -> <CookieInterface>
{
let this->signKey = signKey;
return this;
}

Please note -> <CookieInterface> and return this;.

But this NOT implements Phalcon\Http\Cookie\CookieInterface, it implements Phalcon\Http\Response\CookiesInterface. Missed s.
@sergeyklay sergeyklay added bug A bug report status: unverified Unverified labels May 2, 2020
@sergeyklay sergeyklay self-assigned this May 2, 2020
@sergeyklay sergeyklay removed the status: unverified Unverified label May 2, 2020
sergeyklay added a commit that referenced this issue May 2, 2020
@sergeyklay
Fixed incorrect return type hint for setSignKey
726ece5 
See: #14982
@sergeyklay sergeyklay mentioned this issue May 2, 2020
Merged
5 tasks
@sergeyklay
Copy link
Contributor Author

Fixed in 4.0.x branch

@sergeyklay sergeyklay linked a pull request May 3, 2020 that will close this issue
Fixed incorrect return type hint for setSignKey #14984
Merged
5 tasks
niden pushed a commit that referenced this issue May 16, 2020
@sergeyklay @niden
Fixed incorrect return type hint for setSignKey
6af8c67 
See: #14982
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sergeyklay sergeyklay

Labels
bug A bug report status: low Low
Projects
Phalcon v5
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed incorrect return type hint for setSignKey phalcon/cphalcon
1 participant
@sergeyklay