Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Phalcon\Crypt::getKey may return null #14989

Closed
sergeyklay opened this issue May 3, 2020 · 1 comment · Fixed by #14991
Closed

[BUG]: Phalcon\Crypt::getKey may return null #14989

sergeyklay opened this issue May 3, 2020 · 1 comment · Fixed by #14991
Assignees
Labels
bug A bug report status: low Low

Comments

@sergeyklay
Copy link
Contributor

The current implementation of Phalcon\Crypt::getKey implies that method must return string:

cphalcon/phalcon/Crypt.zep

Lines 427 to 430 in 3049c86

public function getKey() -> string
{
return this->key;
}

however, Phalcon\Crypt::$key is NULL by default:

/**
* @var string
*/
protected key;

This leads to a fatal error:

$crypt = new \Phalcon\Crypt();
$crypt->getKey();
PHP Fatal error:
Return value of Phalcon\Crypt::getKey()
must be of the type string, null returned
@sergeyklay sergeyklay added bug A bug report status: unverified Unverified labels May 3, 2020
@sergeyklay sergeyklay self-assigned this May 3, 2020
@sergeyklay sergeyklay added 4.0.6 and removed status: unverified Unverified labels May 3, 2020
sergeyklay added a commit that referenced this issue May 3, 2020
@sergeyklay sergeyklay linked a pull request May 3, 2020 that will close this issue
5 tasks
@sergeyklay
Copy link
Contributor Author

Fixed in 4.0.x branch

niden pushed a commit that referenced this issue May 16, 2020
@niden niden added this to Phalcon v5 Aug 25, 2022
@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant