[BUG]: Wrong return type hint for Phalcon\Mvc\Model\MetaData::getColumnMap() and Phalcon\Mvc\Model\MetaData::getReverseColumnMap()

[sergeyklay]

Current return type hint of the Phalcon\Mvc\Model\MetaData::getColumnMap as well as Phalcon\Mvc\Model\MetaData::getReverseColumnMap implies that these methods must return an array value. But this method MAY return NULL for some cases:

cphalcon/phalcon/Mvc/Model/MetaData.zep

Lines 188 to 199 in c30f8b4

	public function getColumnMap(<ModelInterface> model) -> array
	{
	var data;
	let data = this->readColumnMapIndex(model, self::MODELS_COLUMN_MAP);
	if unlikely (data !== null && typeof data != "array") {
	throw new Exception("The meta-data is invalid or is corrupt");
	}
	return data;
	}

cphalcon/phalcon/Mvc/Model/MetaData.zep

Lines 420 to 434 in c30f8b4

	public function getReverseColumnMap(<ModelInterface> model) -> array
	{
	var data;
	let data = this->readColumnMapIndex(
	model,
	self::MODELS_REVERSE_COLUMN_MAP
	);
	if unlikely (data !== null && typeof data != "array") {
	throw new Exception("The meta-data is invalid or is corrupt");
	}
	return data;
	}

This leads to a fatal error:

PHP Fatal error:
Return value of Phalcon\Mvc\Model\MetaData::getColumnMap()
must be of the type array, null returned in Unknown on line 0

[sergeyklay]

Fixed in 4.0.x branch