We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Current return type hint of the Phalcon\Mvc\Model\Criteria::getColumns implies that method must return a string or just null:
Phalcon\Mvc\Model\Criteria::getColumns
cphalcon/phalcon/Mvc/Model/Criteria.zep
Lines 334 to 343 in 5c34a6c
But it MAY return an array:
$criteria = new Criteria(); $criteria->columns(['id' => 'inv_id', 'total' => 'inv_total']); // ['id' => 'inv_id', 'total' => 'inv_total'] $criteria->getColumns();
This leads to a fatal error:
PHP Fatal error: Return value of Phalcon\Mvc\Model\Criteria::getColumns() must be of the type string or null, array returned in Unknown on line 0
The text was updated successfully, but these errors were encountered:
Fixed return type for CriteriaInterface::getColumns
c81a274
See: #15017
Fixed in 4.0.x branch
Sorry, something went wrong.
8584392
sergeyklay
Successfully merging a pull request may close this issue.
Current return type hint of the
Phalcon\Mvc\Model\Criteria::getColumns
implies that method must return a string or just null:cphalcon/phalcon/Mvc/Model/Criteria.zep
Lines 334 to 343 in 5c34a6c
But it MAY return an array:
This leads to a fatal error:
The text was updated successfully, but these errors were encountered: