Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Incorrect return type hint of Phalcon\Mvc\Model\Criteria::getColumns() #15017

Closed
sergeyklay opened this issue May 6, 2020 · 1 comment · Fixed by #15018
Closed

[BUG]: Incorrect return type hint of Phalcon\Mvc\Model\Criteria::getColumns() #15017

sergeyklay opened this issue May 6, 2020 · 1 comment · Fixed by #15018
Assignees
Labels
bug A bug report status: low Low

Comments

@sergeyklay
Copy link
Contributor

Current return type hint of the Phalcon\Mvc\Model\Criteria::getColumns implies that method must return a string or just null:

public function getColumns() -> string | null
{
var columns;
if !fetch columns, this->params["columns"] {
return null;
}
return columns;
}

But it MAY return an array:

$criteria = new Criteria();
$criteria->columns(['id' => 'inv_id', 'total'  => 'inv_total']);

// ['id' => 'inv_id', 'total'  => 'inv_total']
$criteria->getColumns();

This leads to a fatal error:

PHP Fatal error:
Return value of Phalcon\Mvc\Model\Criteria::getColumns()
must be of the type string or null, array returned in Unknown on line 0
@sergeyklay
Copy link
Contributor Author

Fixed in 4.0.x branch

@niden niden moved this to Released in Phalcon v5 Aug 25, 2022
@niden niden added this to Phalcon v5 Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A bug report status: low Low
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant