-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG]: Incorrect return type hint of Phalcon\Mvc\Model\Resultset::getFirst #15027
Labels
Comments
sergeyklay
added a commit
that referenced
this issue
May 6, 2020
5 tasks
5 tasks
niden
pushed a commit
that referenced
this issue
May 6, 2020
Implemented in v4.0.x |
niden
pushed a commit
that referenced
this issue
May 16, 2020
niden
pushed a commit
that referenced
this issue
May 31, 2020
the same problem with getLast() method in 4.0.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The current implementation of
Phalcon\Mvc\Model\Resultset::getFirst
implies that method must return aPhalcon\Mvc\ModelInterface
instance or NULL:cphalcon/phalcon/Mvc/Model/Resultset.zep
Lines 311 to 320 in 00fb495
But in some case, it MAY return a
Phalcon\Mvc\Model\Row
instance:This leads to a fatal error:
The text was updated successfully, but these errors were encountered: