[BUG]: Issue with Phalcon\Http\Message\AbstractCommon::cloneInstance

[sergeyklay]

Currently Phalcon\Http\Message\AbstractCommon::cloneInstance clones the passed object and directly modifies object's property:

cphalcon/phalcon/Http/Message/AbstractCommon.zep

Lines 32 to 40 in d59613f

	final protected function cloneInstance(var element, string property) -> var
	{
	var newInstance;
	let newInstance = clone this,
	newInstance->{property} = element;
	return newInstance;
	}

This is not always correct because in some cases object's property is private. For example:

cphalcon/phalcon/Http/Message/Uri.zep

Lines 52 to 59 in d59613f

	/**
	* Returns the path of the URL
	*
	* @return string
	*/
	private path = "" { get };

There is a PoC on PHP just to show the problem:

<?php

abstract class AbstractCommon
{
    final protected function cloneInstance($element, string $property)
    {
        $newInstance             = clone $this;
        $newInstance->{$property} = $element;

        return $newInstance;
    }
}

final class Uri extends AbstractCommon
{
    private $path = "";

    public function withPath(string $path)
    {
        return $this->cloneInstance($path, "path");
    }
}

$test = new Uri();
$test->withPath('action/reaction');

Output:

PHP Fatal error:  Uncaught Error: Cannot access private property Uri::$path in /mnt/work/phalcon/cphalcon/manual.php:8
Stack trace:
#0 /mnt/work/phalcon/cphalcon/manual.php(20): AbstractCommon->cloneInstance('action/reaction', 'path')
#1 /mnt/work/phalcon/cphalcon/manual.php(25): Uri->withPath('action/reaction')
#2 {main}
  thrown in /mnt/work/phalcon/cphalcon/manual.php on line 8

Fatal error: Uncaught Error: Cannot access private property Uri::$path in /mnt/work/phalcon/cphalcon/manual.php:8
Stack trace:
#0 /mnt/work/phalcon/cphalcon/manual.php(20): AbstractCommon->cloneInstance('action/reaction', 'path')
#1 /mnt/work/phalcon/cphalcon/manual.php(25): Uri->withPath('action/reaction')
#2 {main}
  thrown in /mnt/work/phalcon/cphalcon/manual.php on line 8

[sergeyklay]

Fixed in 4.0.x branch