Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Phalcon\Config created by Phalcon\Config should keep insensitive choice #16171

Closed
dugwood opened this issue Oct 19, 2022 · 2 comments · Fixed by #16172
Closed

[BUG]: Phalcon\Config created by Phalcon\Config should keep insensitive choice #16171

dugwood opened this issue Oct 19, 2022 · 2 comments · Fixed by #16172
Assignees
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report

Comments

@dugwood
Copy link
Contributor

dugwood commented Oct 19, 2022

Describe the bug
Phalcon\Config creates instances of Phalcon\Config for all arrays and sub-arrays. These Phalcon\Config should keep the insensitive value as the one of their parent.

To Reproduce
Steps to reproduce the behavior:

$c = ['key' => 'value', 'key_for_array' => ['key' => 'value']];
$config = new Phalcon\Config($c, false);

Expected behavior
$config->key_for_array should have the property insensitive set to false as its parent $config.

Line to change
https://github.com/phalcon/cphalcon/blob/master/phalcon/Config/Config.zep#L253
change for new Config(value, this->insensitive)

Details

  • Phalcon version: 4.1.2
  • PHP Version: 7.4
  • Operating System: Debian
  • Installation type: compiled from source
  • Zephir version (if any): irrelevant
  • Server: irrelevant
@dugwood dugwood added bug A bug report status: unverified Unverified labels Oct 19, 2022
@niden niden mentioned this issue Oct 19, 2022
5 tasks
@niden niden linked a pull request Oct 19, 2022 that will close this issue
5 tasks
@niden
Copy link
Member

niden commented Oct 19, 2022

Resolved in #16172

Thank you @dugwood

@niden niden closed this as completed Oct 19, 2022
@niden niden added this to Phalcon v5 Oct 19, 2022
@niden niden moved this to Backlog in Phalcon v5 Oct 19, 2022
@niden niden moved this from Backlog to Implemented in Phalcon v5 Oct 19, 2022
@dugwood
Copy link
Contributor Author

dugwood commented Oct 19, 2022

Wow, that was fast :-) Thanks @niden!

@niden niden moved this from Implemented to Released in Phalcon v5 Oct 24, 2022
@Jeckerson Jeckerson added 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants