Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Classes that implement Serializable have wrong function declaration #16591

Closed
noone-silent opened this issue May 21, 2024 · 1 comment
Closed
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium

Comments

@noone-silent
Copy link
Contributor

Describe the bug
For example the \Phalcon\Mvc\Model class implements \Serializable. This class is defined as:

interface Serializable {
    public serialize(): ?string
    public unserialize(string $data): void
}

The \Phalcon\Mvc\Model has it implemented like this:

public function serialize() -> string
public function unserialize(var data)

Expected behavior
Follow the interface definition.

Details

  • Phalcon version: 5.6.2
  • PHP Version: 8.2
  • Operating System: debian
  • Installation type: installing via package manager
  • Zephir version (if any): 0.17.0
  • Server: Nginx
  • Other related info (Database, table schema): none
@noone-silent noone-silent added bug A bug report status: unverified Unverified labels May 21, 2024
noone-silent added a commit to noone-silent/cphalcon that referenced this issue May 21, 2024
noone-silent added a commit to noone-silent/cphalcon that referenced this issue May 21, 2024
@niden niden added status: medium Medium 5.0 The issues we want to solve in the 5.0 release and removed status: unverified Unverified labels May 21, 2024
@niden niden added this to Phalcon v5 May 21, 2024
@niden niden moved this to Implemented in Phalcon v5 May 21, 2024
@niden
Copy link
Member

niden commented May 21, 2024

Resolved in #16592

Thank you again @noone-silent

@niden niden closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
Status: Implemented
Development

No branches or pull requests

2 participants