Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for SELECT ALL/SELECT DISTINCT #10156

Merged
merged 3 commits into from
Apr 28, 2015
Merged

Support for SELECT ALL/SELECT DISTINCT #10156

merged 3 commits into from
Apr 28, 2015

Conversation

dreamsxin
Copy link
Contributor

Fix #10143

@KorsaR-ZN
Copy link
Contributor

👍
Thanks!

@andresgutierrez
Copy link
Contributor

Could you please add tests?

@dreamsxin
Copy link
Contributor Author

@andresgutierrez ok

1 similar comment
@dreamsxin
Copy link
Contributor Author

@andresgutierrez ok

@andresgutierrez
Copy link
Contributor

Could you please add tests for SELECT ALL ?

@dreamsxin
Copy link
Contributor Author

@andresgutierrez

That's happen error
https://travis-ci.org/phalcon/cphalcon/builds/60156543

Zephir\ParseException: Syntax error in /home/travis/build/phalcon/cphalcon/phalcon/security.zep on line 185
        let saltBytes = this->getSaltBytes(2);
    ------^

That's is ok.
https://travis-ci.org/dreamsxin/cphalcon/builds/60156536

@andresgutierrez
Copy link
Contributor

Could you please remove this file from your commit? https://github.com/dreamsxin/cphalcon/blob/f01aa1f4e6b4d4f165e5a1ef7afccd9ada5de9b1/ext/phalcon/mvc/model/query/lemon

@dreamsxin
Copy link
Contributor Author

@andresgutierrez Has been deleted.

andresgutierrez added a commit that referenced this pull request Apr 28, 2015
@andresgutierrez
Merge pull request #10156 from dreamsxin/10143
ec581e3 
Support for SELECT ALL/SELECT DISTINCT
@andresgutierrez andresgutierrez merged commit ec581e3 into phalcon:2.0.x Apr 28, 2015
@andresgutierrez
Copy link
Contributor

Thanks

@dreamsxin dreamsxin deleted the 10143 branch July 23, 2015 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dreamsxin @KorsaR-ZN @andresgutierrez