-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.0.x #10247
2.0.x #10247
Conversation
@andresgutierrez $robots = Robots::find();
$paginator= new Phalcon\Paginator\Adapter\Model([
'data' => $robots,
'limit' => 3,
'page' => 1
]);
$paginate = $paginator->getPaginate();
foreach ($paginate->items as $item) {
echo $item->id . ',';
}
// Result in 2.0.x: 1,1,1
// Result in 2.0.0: 1,2,3 |
@KorsaR-ZN I think the paginator tests should be strengthened a little. First they didn't catch the last page bug (was always 1 smaller than what it should be) and now this. I'll look into expanding the test suite for it during the weekend. |
Probably introduced after: #10100 |
ping @patrick-zippenfenig |
@Green-Cat I did improve |
@Green-Cat I'll check #10100 in a few hours. I literally just put my phalcon project into production. Linked in my github profile if someone cares |
@KorsaR-ZN 👍 More tests is always great. |
Possible fix: #10251 |
@andresgutierrez Give me an hour if it is possible. It seems I found another bug with model cache. Need test in new clean project. |
Please see this #10252. I'm not sure, but I think it's a bug |
…ition = 0) was not called before and rolling pointers are in use. Covered now by unit-test
[2.0.x] Model\Resultset: Bugfix for seek(position > 0) operations on plain resultset
[2.0.x] The Model Paginator now iterates over the models.
Update FilterInterface doc
Update Console Application
[2.0.x] Queue methods now return exceptional circumstances first.
[2.0.x] Methods returning `this` in Mvc\Router\Route now have the correct return type
order -> orderBy (order is depreceted)
[2.0.x] Added more parameter/return types to Http
[2.0.x] Mvc\Model::findFirst() now allows hydration
Before merging, please see #10277. |
[2.0.x] The Mvc Router no longer chops off the first character of the params
No description provided.