Added Column::TYPE_TIME #12293
Closed
Added Column::TYPE_TIME #12293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What about https://www.sqlite.org/datatype3.html |
|
As far as I understand there isn't a real time datatype for sqlite. Only datetime with functions to extract time. |
|
@sergeyklay Looking at the other milestones for 3.1.0 I'm expecting a conflict with #11368 that uses 18 also for the const (TYPE_ENUM = 18;). Can you fix this in the merge or should I commit a change to use 19? |
|
@ruudboon of course |
|
@ruudboon Could you please rebase, update CHANGELOG.md and ammend tests |
|
@sergeyklay I'll give it a try. Not really and expert with git, rebasing etc. |
Closed
|
Close in favor of #12471 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding this type solves #12223