Added smallint support in Phalcon\Db #12523
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergeyklay
suggested changes
Jan 3, 2017
There was a problem hiding this comment.
@Studentsov Could you please cover new feature by unit tests?
| @@ -142,6 +142,11 @@ class Column implements ColumnInterface | |||
| const TYPE_TIMESTAMP = 17; | |||
|
|
|||
| /** | |||
| * Small integer abstract type | |||
| */ | |||
| const TYPE_SMALLINTEGER = 18; | |||
There was a problem hiding this comment.
How about just TYPE_SMALLINT?
There was a problem hiding this comment.
We already have a type TYPE_BIGINTEGER. It would be very strange (though quite in the spirit of PHP 😆) to use the name TYPE_SMALLINT.
sergeyklay
approved these changes
Jan 3, 2017
|
Can you add here tinyint support too? |
|
As far is I known, the one-byte integer type isn't provided by the SQL
standard. For example, it isn't in PostgreSQL.
|
|
Oh okay, so it could be at least added to mysql. Not sure about Column class. |
sergeyklay
force-pushed
the
3.1.x
branch
15 times, most recently
from
a848621 to
4d3c73f
Compare
|
@Studentsov Could you be so kind as to rebase this for the Apologies for letting this linger for this long |
|
Addressed in #13562 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds the capability to use the data type smallint, which is part of the SQL standard and is well supported by major DBMS. This data type uses 2 bytes instead of 4 bytes for type int, which will save memory if you don't need large numeric values.