Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dynamic update soft delete for renamed model does not work as exp… #13307

Merged
merged 4 commits into from
Feb 28, 2018

Conversation

limingxinleo
Copy link
Contributor

@limingxinleo limingxinleo commented Feb 24, 2018

…ected!

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Thanks

@virgofx
Copy link
Contributor

virgofx commented Feb 25, 2018

I believe this also fixes the similar issue: #13302

The solution in 13302 is also what was done in this solution.

Ping @Jurigag to confirm.

@Jurigag
Copy link
Contributor

Jurigag commented Feb 26, 2018

Looks like fine, though appveyor fails.

@sergeyklay sergeyklay added this to the 3.3.x milestone Feb 26, 2018
@sergeyklay
Copy link
Contributor

@limingxinleo Could you please update change log? @Jurigag I'll fix AppVeyor's build a bit later.

@limingxinleo
Copy link
Contributor Author

@sergeyklay done

@limingxinleo
Copy link
Contributor Author

I just updated a releasenote.md.

oh my god...

@sergeyklay sergeyklay merged commit c8c4f03 into phalcon:3.3.x Feb 28, 2018
@sergeyklay
Copy link
Contributor

Thank you

@virgofx
Copy link
Contributor

virgofx commented Feb 28, 2018

Thank you. ETA for patch release? Need this in production

@sergeyklay
Copy link
Contributor

@virgofx I'll try to release next weekend

@virgofx
Copy link
Contributor

virgofx commented Mar 1, 2018

Perfect 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants