Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#13468] - Added getHandlerSuffix(), setHandlerSuffix() in Dispatcher #13536

Merged
merged 2 commits into from
Oct 18, 2018
Merged

[#13468] - Added getHandlerSuffix(), setHandlerSuffix() in Dispatcher #13536

merged 2 commits into from
Oct 18, 2018

Conversation

niden
Copy link
Member

@niden niden commented Oct 18, 2018

Hello!

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the Contributing Guidelines?
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Added missing methods; ability to retrieve properties from the dispatcher

Thanks

@niden
[#13468] - Added getHandlerSuffix(), setHandlerSuffix() in Dispat…
9352591 
…cher, `getTaskSuffix()`, `setTaskSuffix()` in the CLI Dispatcher
@niden niden requested a review from sergeyklay October 18, 2018 22:03
@niden niden self-assigned this Oct 18, 2018
@niden niden added Bug - Medium enhancement Enhancement to the framework labels Oct 18, 2018
@niden niden added this to the 4.0.0 milestone Oct 18, 2018
@niden
Copy link
Member Author

niden commented Oct 18, 2018

cc @sergeyklay

@sergeyklay sergeyklay added the breaks bc Functionality that breaks Backwards Compatibility label Oct 18, 2018
@sergeyklay
Copy link
Contributor

I've added the Breaks BC label. Because there is interface changes so old applications will need update their custom implementations (if any)

@niden niden merged commit 9390b61 into phalcon:4.0.x Oct 18, 2018
@niden niden deleted the T13468-inconsistent-naming-convention-in-dispatcher-2 branch October 31, 2018 17:44
@niden niden added the documentation Documentation required label Apr 9, 2019
@niden niden added 4.0 and removed documentation Documentation required labels Dec 1, 2019
@niden niden added bug A bug report status: medium Medium and removed Bug - Medium labels Dec 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeyklay sergeyklay sergeyklay approved these changes

Assignees

@niden niden

Labels
breaks bc Functionality that breaks Backwards Compatibility bug A bug report enhancement Enhancement to the framework status: medium Medium
Projects
None yet
Milestone
4.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@niden @sergeyklay