Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Phalcon\Validation::preChecking #13575

Merged
merged 1 commit into from
Nov 3, 2018
Merged

Fixed Phalcon\Validation::preChecking #13575

merged 1 commit into from
Nov 3, 2018

Conversation

sergeyklay
Copy link
Contributor

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist.
  • I wrote some tests for this PR.

Small description of change:

Fixed Phalcon\Validation::preChecking to allow use Phalcon\Db\RawValue as an empty container for isAllowEmpty option. Please see #13573 for the reproducible test.

Thanks

@sergeyklay sergeyklay merged commit f75f328 into 3.4.x Nov 3, 2018
@sergeyklay sergeyklay deleted the fix/validator-is-allow-empty branch November 3, 2018 13:26
This was referenced Nov 3, 2018
Closed
Merged
@niden niden added documentation Documentation required and removed documentation Documentation required labels Apr 9, 2019
@niden niden added the 4.0 label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyklay @niden