-
-
Couldn't load subscription status.
- Fork 2k
Travis now uses Ubuntu 18.04 for builds #14268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general looks good to me
|
It's a little bit confusing with the bugs in the getAllKeys() method
|
|
@SidRoberts Could you please change memcached version check to reflect this Make sure you use php-memcached extension >= 3.0.1 and memcached server >= 1.4.24 |
|
I agree that this is very confusing. Currently Travis is using Memcached server 1.5.6 and Memcached extension 3.1.3. In theory, it should work but it doesn't. I don't like the idea of a test doing version checking. I think the version checks should be in the How about keep the version check at >=1.2.24 for now, merge it and then deal with it later? |
|
Or, as a last ditch effort, what about bc0712e? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good 👍
|
Thank you |
Hello!
In raising this pull request, I confirm the following:
Two important things of note:
I've tried to alter the code to work around these problems but I'd like someone with a fresh set of eyes to double check as I've been looking at this too long. 😜